Re: JSON-RPC password

Quote from: lachesis on July 25, 2010, 19:52:35
I found what appears to be a bug: with a long enough username and password combination, the base64 encoder in bitcoind produces authorization headers that look like this:

Authorization: Basic YWJiYWJiYWFiYmE6aGVsbG93b3JsZGhlbGxvd29ybGRoZWxsb3dvcmxkaGVsbG93

It inserts a newline every 64 characters, which obviously breaks the Authorization header, so commands like “bitcoin getinfo” fail. The server still works fine with properly behaving clients.

This can be solved by removing the newlines (and maybe ‘\r’s) from result at the end of the Base64Encode function:

result.erase(std::remove(result.begin(), result.end(), '\n'), result.end());
result.erase(std::remove(result.begin(), result.end(), '\r'), result.end());

+1 to you for having such a long password that you found this bug.

Uploaded to SVN as rev 110.

10,864 total views, 2 views today